Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embedded multi-target Prometheus exporters can't be provided discovered targets #273

Open
rfratto opened this issue Jan 18, 2024 · 3 comments · May be fixed by #997
Open

Embedded multi-target Prometheus exporters can't be provided discovered targets #273

rfratto opened this issue Jan 18, 2024 · 3 comments · May be fixed by #997
Labels
bug Something isn't working

Comments

@rfratto
Copy link
Member

rfratto commented Jan 18, 2024

Multi-target exporters (such as snmp_exporter) can have a dynamic set of targets passed to them through the scrape config.

However, in Grafana Agent, our embedded version of these exporters only accept hard-coded targets, preventing the kind of dynamic behaviour Prometheus users would expect.

I see this as a bug: using the embedded multi-target exporter should be equally as capable as using the external multi-target exporter.

We should investigate and fix this issue in all embedded multi-target exporters.

@rfratto rfratto added the bug Something isn't working label Jan 18, 2024
@djcode
Copy link

djcode commented Jan 29, 2024

I'd love to see these exporters reimplemented in a way that allows dynamic targets, but in case anyone sees this and needs it now, I wrote a module that adds the ability for dynamic targets to blackbox exporter, the same logic works for snmp exporter. https://github.com/grafana/agent-modules/tree/main/modules/grafana-agent/dynamic-blackbox

Copy link
Contributor

This issue has not had any activity in the past 30 days, so the needs-attention label has been added to it.
If the opened issue is a bug, check to see if a newer release fixed your issue. If it is no longer relevant, please feel free to close this issue.
The needs-attention label signals to maintainers that something has fallen through the cracks. No action is needed by you; your issue will be kept open and you do not have to respond to this comment. The label will be removed the next time this job runs if there is new activity.
Thank you for your contributions!

@rfratto
Copy link
Member Author

rfratto commented Apr 11, 2024

Hi there 👋

On April 9, 2024, Grafana Labs announced Grafana Alloy, the spirital successor to Grafana Agent and the final form of Grafana Agent flow mode. As a result, Grafana Agent has been deprecated and will only be receiving bug and security fixes until its end-of-life around November 1, 2025.

To make things easier for maintainers, we're in the process of migrating all issues tagged variant/flow to the Grafana Alloy repository to have a single home for tracking issues. This issue is likely something we'll want to address in both Grafana Alloy and Grafana Agent, so just because it's being moved doesn't mean we won't address the issue in Grafana Agent :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants