Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.39.0 on Windows 10 does not use new Environment registry entry under $hklm\SOFTWARE\Grafana\Grafana Agent Flow #272

Open
gregprior opened this issue Jan 18, 2024 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@gregprior
Copy link

What's wrong?

Version 0.39.0 moved the Environment registry entry from the service registry entry to the program registry entry for other Windows systems.

Steps to reproduce

modify the river file to require an environment variable and add that variable to $hklm\SOFTWARE\Grafana\Grafana Agent Flow and the service will fail to start.
Add the variable to $hklm\SYSTEM\CurrentControlSet\Services\Grafana Agent Flow Environment entry and the service will start

System information

Windows 10.0.19045.3930

Software version

Grafana Agent Flow v0.39.0

Configuration

No response

Logs

Error: C:\river\config.river:34:1: Failed to build component: building component: OTLP exporter config requires an Endpoint

33 |   }
34 |   otelcol.exporter.otlp "tempo_endpoint" {
   |  _^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
35 | |   client {
36 | |     endpoint = env("TEMPO_URL")
37 | |     auth     = otelcol.auth.basic.tempo.handler
39 | |   }
40 | | }
   | |_^
41 |   otelcol.auth.basic "tempo" {
@gregprior gregprior added the bug Something isn't working label Jan 18, 2024
@mattdurham mattdurham self-assigned this Jan 18, 2024
@mattdurham
Copy link
Collaborator

Its hard coded to Software\Grafana\Grafana Agent Flow, can you share the registry key values you have?

@gregprior
Copy link
Author

gregprior commented Jan 21, 2024

in this case, it is just the TEMPO_URL. if it is only in SOFTWARE\Grafana\Grafana Agent Flow Environment entry, then it fails.
If it is in the one for the SYSTEM\CurrentControlSet\Services..., then the ENVIRONMENT seems to get passed along to the program environment running under the service.
This works fine for the Server 2012R2, 2016, 2019 and 2022 systems. It fails on Windows 10. I haven't tried Windows 11.

Copy link
Contributor

This issue has not had any activity in the past 30 days, so the needs-attention label has been added to it.
If the opened issue is a bug, check to see if a newer release fixed your issue. If it is no longer relevant, please feel free to close this issue.
The needs-attention label signals to maintainers that something has fallen through the cracks. No action is needed by you; your issue will be kept open and you do not have to respond to this comment. The label will be removed the next time this job runs if there is new activity.
Thank you for your contributions!

@rfratto
Copy link
Member

rfratto commented Apr 11, 2024

Hi there 👋

On April 9, 2024, Grafana Labs announced Grafana Alloy, the spirital successor to Grafana Agent and the final form of Grafana Agent flow mode. As a result, Grafana Agent has been deprecated and will only be receiving bug and security fixes until its end-of-life around November 1, 2025.

To make things easier for maintainers, we're in the process of migrating all issues tagged variant/flow to the Grafana Alloy repository to have a single home for tracking issues. This issue is likely something we'll want to address in both Grafana Alloy and Grafana Agent, so just because it's being moved doesn't mean we won't address the issue in Grafana Agent :)

@rfratto rfratto transferred this issue from grafana/agent Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants