Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resync defaults for otelcol.extension.jaeger_remote_sampling with upstream #219

Open
tpaschalis opened this issue Mar 12, 2024 · 1 comment
Open

Resync defaults for otelcol.extension.jaeger_remote_sampling with upstream #219

tpaschalis opened this issue Mar 12, 2024 · 1 comment
Labels
enhancement New feature or request needs-attention

Comments

@tpaschalis
Copy link
Member

In our fork of the jaeger_remote_sampling extension we define the default http and grpc endpoints as

https://github.com/grafana/agent/blob/2603bda1660254f57f22e42ac3b47ab2ef58eb6e/internal/component/otelcol/extension/jaeger_remote_sampling/internal/jaegerremotesampling/factory.go#L44-L52

whereas the upstream code either adds 0.0.0.0 or localhost as a prefix based on a feature flag.

https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/a7ffded40d597a6c3e1f3e755f3cb9135778e5bc/internal/common/localhostgate/featuregate.go#L52-L58

Let's not forget to update the defaults once we update our OpenTelemetry dependency.

cc @ptodev
@hainenber hainenber mentioned this issue Mar 24, 2024
Closed
4 tasks
@rfratto rfratto added the enhancement New feature or request label Apr 9, 2024
@rfratto rfratto transferred this issue from grafana/agent Apr 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

This issue has not had any activity in the past 30 days, so the needs-attention label has been added to it.
If the opened issue is a bug, check to see if a newer release fixed your issue. If it is no longer relevant, please feel free to close this issue.
The needs-attention label signals to maintainers that something has fallen through the cracks. No action is needed by you; your issue will be kept open and you do not have to respond to this comment. The label will be removed the next time this job runs if there is new activity.
Thank you for your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request needs-attention
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(otelcol/extension/jaeger_remote_sampling): resync defaults with upstreams hainenber/agent
2 participants
@rfratto @tpaschalis