Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modules: support relative path #786

Open
wildum opened this issue May 7, 2024 · 1 comment · May be fixed by #789
Open

Modules: support relative path #786

wildum opened this issue May 7, 2024 · 1 comment · May be fixed by #789
Assignees
Labels
enhancement New feature or request needs-attention

Comments

@wildum
Copy link
Contributor

wildum commented May 7, 2024

Background

The import.file block imports custom components from a file or a directory and exposes them to the importer. Users can specify the path to watch via the argument filename.

Problem

The path is relative to the current working directory. This works fine when importing a module from the root config but it’s not ideal when the module itself has import.file blocks. Resolving the path relative to the module would be better in this case.

Request

The following use-cases should be supported:

  • import.file -> import.file
  • import.git -> import.file
  • import.string -> import.file

And if possible import.http -> import.file, but this one might be more tricky because it would only be possible if the nested import.file blocks would be turned into import.http blocks.

@wildum wildum added the enhancement New feature or request label May 7, 2024
@wildum wildum self-assigned this May 7, 2024
Copy link
Contributor

github-actions bot commented Jun 8, 2024

This issue has not had any activity in the past 30 days, so the needs-attention label has been added to it.
If the opened issue is a bug, check to see if a newer release fixed your issue. If it is no longer relevant, please feel free to close this issue.
The needs-attention label signals to maintainers that something has fallen through the cracks. No action is needed by you; your issue will be kept open and you do not have to respond to this comment. The label will be removed the next time this job runs if there is new activity.
Thank you for your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs-attention
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant