Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the virtual_node_peer_attributes setting to otelcol.connector.servicegraph #861

Open
madaraszg-tulip opened this issue May 15, 2024 · 1 comment · May be fixed by #879
Open

Add the virtual_node_peer_attributes setting to otelcol.connector.servicegraph #861

madaraszg-tulip opened this issue May 15, 2024 · 1 comment · May be fixed by #879
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@madaraszg-tulip
Copy link

Request

The upstream servicegraphconnector has moved the virtual nodes feature to stage beta, it is automatically enabled now in grafana alloy 1.1.0.

Use case

I would like to configure the attributes used for determining virtual nodes
@madaraszg-tulip madaraszg-tulip added the enhancement New feature or request label May 15, 2024
@ptodev ptodev added help wanted Extra attention is needed good first issue Good for newcomers labels May 15, 2024
@ptodev
Copy link
Contributor

ptodev commented May 15, 2024

If OTel has enabled it by default, then it would be ok for us to incorporate it. The dev team is a bit busy right now so I'll let the issue stay open for now in case someone from the community would like to contribute it :)

@hainenber hainenber linked a pull request May 16, 2024 that will close this issue
Draft
4 tasks
@madaraszg-tulip madaraszg-tulip mentioned this issue May 16, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
2 participants
@ptodev @madaraszg-tulip