Ability to select result format is missing.

[yesoreyeram]

Some query results failed to display in explore mode due to incorrect "data.FrameMeta.PreferredVisualization" settings. Also looks like we don't have format selector in the frontend.

[yesoreyeram]

@scottlepp - I see the following code

astradb-datasource/src/components/CQLEditor.tsx

Lines 43 to 44 in 31b7b96

	const format = sql.toLowerCase().includes('as time') ? Format.TIMESERIES : Format.TABLE;
	onChange({ ...query, rawCql: sql, format }, true);

is doing automatic format computation based on query string. This is problematic when you want to visualise a table with time field. Also this is problematic when user want to visualise the data as logs.

Also I see we defaults to timeseries, where most cases user receive tabular data. WDYT?

[scottlepp]

hmm doesn't it default to table if they don't have an "as time" alias?

const format = sql.toLowerCase().includes('as time') ? Format.TIMESERIES : Format.TABLE; 

[yesoreyeram]

no. Default format is not set anywhere.. so the go code fallback to 0 (timeseries).

astradb-datasource/pkg/plugin/plugin.go

Line 62 in 31b7b96

Format sqlds.FormatQueryOption

and the following fallsback to timeseries

astradb-datasource/pkg/plugin/framer.go

Lines 52 to 82 in 31b7b96

	frame.Meta = &data.FrameMeta{
	ExecutedQueryString: qm.ActualCql,
	PreferredVisualization: data.VisTypeGraph,
	Notices: notices,
	}
	if qm.Format == sqlds.FormatOptionTable {
	frame.Meta.PreferredVisualization = data.VisTypeTable
	return frame, nil
	}
	if qm.Format == sqlds.FormatOptionLogs {
	frame.Meta.PreferredVisualization = data.VisTypeLogs
	return frame, nil
	}
	if frame.TimeSeriesSchema().Type == data.TimeSeriesTypeLong {
	fillMode := &data.FillMissing{Mode: data.FillModeNull}
	if shouldSort(qm.RawCql) {
	sortByTime(frame)
	}
	frame, err := data.LongToWide(frame, fillMode)
	if err != nil {
	return nil, err
	}
	return frame, nil
	}
	return frame, nil

[yesoreyeram]

also sql.toLowerCase().includes('as time') doesn't makes sense when user have time field in table.

select server_name, restarted_time as time from servers doesn't qualify timeseries. WDYT?