Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor to make use of latest grafana/data package #482

Closed
aangelisc opened this issue Sep 29, 2022 · 3 comments
Closed

Refactor to make use of latest grafana/data package #482

aangelisc opened this issue Sep 29, 2022 · 3 comments
Labels
datasource/ADX effort/none good first issue Good for newcomers type/chore

Comments

@aangelisc
Copy link
Contributor

aangelisc commented Sep 29, 2022 •
edited by vickyyyyyyy

Improved types have been introduced in the latest grafana/data package. Foremost amongst these is improved typing for template variables. ADX should be updated so that we can improve our typings and reduce the amount of any being used (particularly in tests).

In scope
Update grafana/data package to latest

Out of scope
Figuring out the types (separate ticket to be created)
@aangelisc aangelisc added type/bug Something isn't working datasource/ADX type/chore and removed type/bug Something isn't working labels Sep 29, 2022
@andresmgot
Copy link
Contributor

which version includes this? We are already at 9.1.5

@aangelisc
Copy link
Contributor Author

The change was introduced here which has been released in the 9.2.0 beta I believe so this refactor will have to wait for the 9.2.0 release.

@aangelisc aangelisc added the good first issue Good for newcomers label Jan 3, 2023
@aangelisc
Copy link
Contributor Author

We're using 9.5.10 now so this is complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
datasource/ADX effort/none good first issue Good for newcomers type/chore
Projects
Partner Datasources
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andresmgot @aangelisc