Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All requests should use user identity auth if user identity configured #509

Closed
Tracked by #366
kostrse opened this issue Nov 4, 2022 · 1 comment · Fixed by #533
Closed
Tracked by #366

All requests should use user identity auth if user identity configured #509

kostrse opened this issue Nov 4, 2022 · 1 comment · Fixed by #533
Labels

Comments

@kostrse
Copy link
Contributor

kostrse commented Nov 4, 2022

When user configures OBO authentication then some requests authenticated using the user identity of OBO and some continue to use service identity directly.

Properly using user identity:

Methods using service identity directly (need to be fixed):

  • CheckHealth(here)
  • CallResource getDatabases (here)
  • CallResource getSchema (here)

Regardless of type of the request, authentication method should be consistent with user's configuration.

@kostrse
Copy link
Contributor Author

kostrse commented Dec 13, 2022

This PR #525 isolates the issue to CheckHealth (here).

Short term solution for CheckHealth would be to temporary remove server-side implementation and implement it via testDatasource() on frontend which would make a normal query request.

Ideal solution would be grafana/grafana-plugin-sdk-go#579 to include IdToken to req.PluginContext.User (here), so ID token could be accessed from the User struct regardless of which backend func was called (query req, resource call, etc.).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants