Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move usage tracking from business layer to ADX client #526

Closed
kostrse opened this issue Dec 16, 2022 · 0 comments · Fixed by #862
Closed

Move usage tracking from business layer to ADX client #526

kostrse opened this issue Dec 16, 2022 · 0 comments · Fixed by #862
Assignees
@aangelisc
Labels
datasource/ADX effort/small type/bug Something isn't working

Comments

@kostrse
Copy link
Contributor

kostrse commented Dec 16, 2022

modelQuery() func takes backend.User as an argument and sets headers x-ms-user-id, x-ms-client-request-id.

This should not be a part of business layer and moved to the ADX client.

ADX client will have access to adxcontext.CurrentUserContext (#525) which includes backend.User to implement all necessary usage tracking transparently for business layer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aangelisc aangelisc

Labels
datasource/ADX effort/small type/bug Something isn't working
Projects
Partner Datasources
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move tracking headers to client grafana/azure-data-explorer-datasource
2 participants
@kostrse @aangelisc