Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typing of getCredentials/updateCredentials #530

Closed
kostrse opened this issue Jan 3, 2023 · 1 comment
Closed

Fix typing of getCredentials/updateCredentials #530

kostrse opened this issue Jan 3, 2023 · 1 comment
Labels
datasource/ADX effort/none good first issue Good for newcomers type/chore

Comments

@kostrse
Copy link
Contributor

kostrse commented Jan 3, 2023

Currently, src/components/ConfigEditor/AzureCredentialsConfig.ts uses type DataSourceSettings<any, any> for datasource options.

The typing needs to be reviewed, to avoid usage of any.

It's possible that typing of DataSourceJsonData and S type parameters of DataSourceSettings in @grafana/data is inaccurate.

JsonData and SecureJsonData are property bags and should allow random key/value access but they are not typed as such.

Original discussion here:
#529 (comment)
@kostrse kostrse added datasource/ADX type/bug Something isn't working labels Jan 3, 2023
@kostrse kostrse mentioned this issue Jan 3, 2023
Merged
@aangelisc aangelisc added good first issue Good for newcomers type/chore and removed type/bug Something isn't working labels Jun 9, 2023
@kostrse kostrse mentioned this issue Jan 16, 2024
Open
@aangelisc
Copy link
Contributor

Closing this as this issue is more related to the underlying Grafana types than the data source specifically. We're also planning on rectifying this via the Azure React SDK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
datasource/ADX effort/none good first issue Good for newcomers type/chore
Projects
Partner Datasources
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kostrse @aangelisc