Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration for On-Behalf-Of authentication via AzureSettings #555

Closed
Tracked by #573
kostrse opened this issue Feb 1, 2023 · 2 comments
Closed
Tracked by #573

Configuration for On-Behalf-Of authentication via AzureSettings #555

kostrse opened this issue Feb 1, 2023 · 2 comments
Labels

Comments

@kostrse
Copy link
Contributor

kostrse commented Feb 1, 2023

On-Behalf-Of feature currently controlled by the adxOnBehalfOf feature toggle.

Since we are on the path for stabilization of the On-Behalf-Of feature and standard feature flags are not accessible from backend of external datasources, the proposal is to introduce a permanent option switch in the azsettings.AzureSettings structure.

OBO switch can be added into [azure] configuration section (here):

[azure]
managed_identity_enabled = true

# Enable/disable On-Behalf-Of authentication using AAD client configured in a datasource
client_obo_enabled = false

This configuration section parsed here into azsettings.AzureSettings structure.

We will need to extend the azsettings.AzureSettings in github.com/grafana/grafana-azure-sdk-go/azsettings/settings.go with additional boolean fiend and then update the github.com/grafana/grafana-azure-sdk-go package in Grafana.

Related discussion: #359 (comment)

@kostrse kostrse added datasource/ADX type/bug Something isn't working labels Feb 1, 2023
@kostrse
Copy link
Contributor Author

kostrse commented Feb 1, 2023

@aangelisc aangelisc removed the type/bug Something isn't working label Feb 1, 2023
@asimpson
Copy link
Contributor

asimpson commented Feb 3, 2023

Sorry for the delay @kostrse! I went ahead and approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

3 participants