Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sarama to v1.23.0 #443

Closed
D3luxee opened this issue Oct 30, 2020 · 0 comments · Fixed by #445
Closed

Update sarama to v1.23.0 #443

D3luxee opened this issue Oct 30, 2020 · 0 comments · Fixed by #445

Comments

@D3luxee
Copy link
Contributor

D3luxee commented Oct 30, 2020

The sarama dependency should be updated to v1.23.0 (same version as metrictank 1.0).

This will allow users of carbon-relay-ng to use the same versions of kafka as in metrictank which reduces the conversions made by kafka.

carbon-relay-ng currently uses sarama 1.19.0 which supports kafka up to version 2.0.0, metrictank with sarama 1.23.0 supports kafka up to version 2.3.0.

If the producers and consumers work on different versions of sarama / the used kafka version is not supported by one them kafka has to do conversions which reduces the performance of kafka and increases the load.
https://medium.com/@jiangtaoliu/a-lesson-learning-of-kafka-message-conversions-4a9a091759a5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant