Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests with XFilesFactor for functions that support that parameter #103

Closed
carrieedwards opened this issue Sep 9, 2022 · 0 comments · Fixed by #107
Closed

Add tests with XFilesFactor for functions that support that parameter #103

carrieedwards opened this issue Sep 9, 2022 · 0 comments · Fixed by #107
Labels
enhancement New feature or request

Comments

@carrieedwards
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Currently, several of the functions that support xFilesFactor as an argument, such as aggregate and aggregateSeriesLists, are missing tests that specify an XFilesFactor. These tests should be added for improved code coverage.

Describe the solution you'd like
Tests specifying an XFilesFactor should be added for functions that support that argument.
@carrieedwards carrieedwards added the enhancement New feature or request label Sep 9, 2022
@carrieedwards carrieedwards linked a pull request Sep 9, 2022 that will close this issue
Fix xFilesFactor handling in AggregateSeries and add tests #107
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix xFilesFactor handling in AggregateSeries and add tests grafana/carbonapi
1 participant
@carrieedwards