Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent panic in fallbackSeries function if only one series is specified #108

Closed
carrieedwards opened this issue Sep 12, 2022 · 0 comments · Fixed by #109
Closed

Prevent panic in fallbackSeries function if only one series is specified #108

carrieedwards opened this issue Sep 12, 2022 · 0 comments · Fixed by #109
Labels
bug Something isn't working

Comments

@carrieedwards
Copy link
Collaborator

Describe the bug

The fallbackSeries function will panic if only one series if passed in, as it expects two series (see Graphite web documentation. If only one series is provided to this function, then it should fail with an ErrMissingTimeSeries, but not panic.
@carrieedwards carrieedwards added the bug Something isn't working label Sep 12, 2022
@carrieedwards carrieedwards linked a pull request Sep 12, 2022 that will close this issue
Prevent panic in fallbackSeries function if only one argument is provided #109
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prevent panic in fallbackSeries function if only one argument is provided grafana/carbonapi
1 participant
@carrieedwards