Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for optional parameters for linearRegression #41

Open
npazosmendez opened this issue Jul 28, 2022 · 1 comment
Open

Add support for optional parameters for linearRegression #41

npazosmendez opened this issue Jul 28, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@npazosmendez
Copy link

Is your feature request related to a problem? Please describe.

The official docs say linearRegression supports two optional parameters that change the range of the linear regression: linearRegression(seriesList, startSourceAt=None, endSourceAt=None). See here. CarbonAPI does not support these. It uses the from/to from the input series and just fills out the NaNs.

Describe the solution you'd like

The startSourceAt and endSourceAt should be used if passed to shift the ranges of the linear regression.

Additional context
We already tried to add support for this #40 but realized it requires more knowledge on how the regression is computed. And since it's not a priority for us right now, we are creating this issue for later.

@npazosmendez npazosmendez added the enhancement New feature or request label Jul 28, 2022
@npazosmendez
Copy link
Author

@carrieedwards was this one addressed? I can't find a PR either

@carrieedwards carrieedwards reopened this Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants