Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keepLastValue fails if inf passed as parameter for limit #81

Closed
carrieedwards opened this issue Aug 26, 2022 · 0 comments · Fixed by #83
Closed

keepLastValue fails if inf passed as parameter for limit #81

carrieedwards opened this issue Aug 26, 2022 · 0 comments · Fixed by #83
Labels
bug Something isn't working

Comments

@carrieedwards
Copy link
Collaborator

keepLastValue has a limit parameter with a default value of inf. However, if inf is passed in for the parameter, it throws an ErrBadType because the argument is expected to be an integer. To be consistent with Graphite web and to prevent this error from being thrown, inf should be an accepted value for the limit parameter.
@carrieedwards carrieedwards added the bug Something isn't working label Aug 26, 2022
@carrieedwards carrieedwards linked a pull request Aug 26, 2022 that will close this issue
Allow inf as value for limit parameter in keepLastValue #83
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow inf as value for limit parameter in keepLastValue grafana/carbonapi
1 participant
@carrieedwards