Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DivideSeriesLists not aligning numerators and denominators #97

Closed
carrieedwards opened this issue Sep 6, 2022 · 0 comments · Fixed by #99
Closed

DivideSeriesLists not aligning numerators and denominators #97

carrieedwards opened this issue Sep 6, 2022 · 0 comments · Fixed by #99
Labels
bug Something isn't working

Comments

@carrieedwards
Copy link
Collaborator

Describe the bug
The divideSeriesLists function is currently returning an error if the step times of the numerator and denominator are not equal. This is not consistent with Graphite web's implementation, which finds the LCM of the step and then consolidates based on that step time. CarbonAPI's handling of mismatched steps in series should be the same as Graphite web's.
@carrieedwards carrieedwards added the bug Something isn't working label Sep 6, 2022
@carrieedwards carrieedwards linked a pull request Sep 7, 2022 that will close this issue
Align series by step in *seriesLists functions if steps or value length not equal #99
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Align series by step in *seriesLists functions if steps or value length not equal grafana/carbonapi
1 participant
@carrieedwards