Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raw query editor to visual query builder improvements #137

Closed
bossinc opened this issue Jun 16, 2022 · 0 comments · Fixed by #287
Closed

Raw query editor to visual query builder improvements #137

bossinc opened this issue Jun 16, 2022 · 0 comments · Fixed by #287
Assignees

Comments

@bossinc
Copy link
Collaborator

bossinc commented Jun 16, 2022

Currently, there are several glitches with converting from the raw query editor to the visual editor because of the AST. We no longer plan to support our AST, so we need a new solution for this problem. We can leverage an open-source AST to support this conversion.

Improvements

  • use oguimbal/pgsql-ast-parser as the AST and replace AST (We use a Postgress AST parser because this is the most developed and active ts/js AST parser. No open-source CH AST parsers are being developed. I tried writing a custom AST parser but ran into too many complex issues that became too time-consuming to solve correctly.)
  • process AST before trying to convert and prevent users from converting. Also, when able, give details as to why it cannot convert
  • support parsing grafana functions in the new AST (either by extending it or some clever way)
@bossinc bossinc added the enhancement New feature or request label Jun 16, 2022
@bossinc bossinc self-assigned this Jun 16, 2022
@bossinc bossinc linked a pull request Feb 2, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants