Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to add csv format in query for grafana output #278

Closed
hackaholic opened this issue Jan 17, 2023 · 2 comments
Closed

Option to add csv format in query for grafana output #278

hackaholic opened this issue Jan 17, 2023 · 2 comments
Labels
datasource/ClickHouse effort/none enhancement New feature or request invalid This doesn't seem right

Comments

@hackaholic
Copy link

hackaholic commented Jan 17, 2023

By default Grafana append FORMAT JSON to the query, there should be more option format like csv

As due to format JSON rendering time of query is increased exponentially , the same query with CSV format dumps results very fast.

The query with FORMAT JOSN took 170 sec
39309 rows in set. Elapsed: 170.178 sec. Processed 1.02 million rows, 128.34 MB (6.00 thousand rows/s., 754.17 KB/s.)

The same query with FORMAT CSV took only 4 sec
39309 rows in set. Elapsed: 4.084 sec. Processed 1.02 million rows, 128.34 MB (250.06 thousand rows/s., 31.42 MB/s.)

Example: From Grafana Query inspector

Object
request:Object
url:"api/datasources/proxy/1/?database=pw"
method:"POST"
**data**:"select  * from system.clusters where cluster='iond_shard' FORMAT JSON"     <----------------
hideFromInspector:false
response:Object
@bossinc bossinc added the enhancement New feature or request label Jan 30, 2023
@gingerwizard
Copy link
Collaborator

gingerwizard commented Mar 21, 2023

We communicate over FORMAT Native via the go client - the most optimal. There is no use of JSON Format.
We have no reason to add this.

@gingerwizard gingerwizard added the invalid This doesn't seem right label Mar 21, 2023
@gingerwizard
Copy link
Collaborator

I don't think this is the datasource plugin @hackaholic @vickyyyyyyy but the monitoring plugin?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datasource/ClickHouse effort/none enhancement New feature or request invalid This doesn't seem right
Projects
Archived in project
Development

No branches or pull requests

4 participants