Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make nested struct generation works #19

Closed
ying-jeanne opened this issue Aug 25, 2021 · 2 comments · Fixed by #23
Closed

Make nested struct generation works #19

ying-jeanne opened this issue Aug 25, 2021 · 2 comments · Fixed by #23
Assignees
Labels
kind/feature New feature or request

Comments

@ying-jeanne
Copy link
Collaborator

An example of expected input/output of cuetsy: https://gist.github.com/sdboyer/5d0b9e8e7ba0f60e427c84626a0eb11a

@sdboyer sdboyer added the kind/feature New feature or request label Aug 25, 2021
@sdboyer
Copy link
Contributor

sdboyer commented Aug 25, 2021

Indeed, we absolutely need to have codegen work for nested structs. It may be kinda tricky to implement, but there's no way around it.

@ying-jeanne ying-jeanne self-assigned this Aug 26, 2021
@ying-jeanne ying-jeanne linked a pull request Aug 27, 2021 that will close this issue
@ying-jeanne ying-jeanne added this to To do in Grafana Backend (DO NOT USE!) via automation Aug 30, 2021
@ying-jeanne ying-jeanne moved this from To do to In progress in Grafana Backend (DO NOT USE!) Aug 30, 2021
@ying-jeanne ying-jeanne added this to the 8.2.0 milestone Aug 30, 2021
@ying-jeanne
Copy link
Collaborator Author

The generation of nested struct itself is easy, but to generate the default is a bit tricky. writing down some test cases that should be covered by the code.
(pre-calculate the depth of nested struct, then go iteratively would not work? since a nested struct could contains several children, and each of them could have different depth?)

Grafana Backend (DO NOT USE!) automation moved this from In progress to Done Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants