-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check every query for a counter (_total
) is irate
'd, and that we never use rate
#55
Comments
Hi not sure about the explanation, it seems to me that this thread explains more the disadvantages of using irate than anything else? I also think that rate should be preferred over irate almost everywhere... |
@MrFreezeex Yes that is the consensus and we will be putting in a check for that in the dashboard linter. I will remove the link to the confusing discussion :) |
Do you mind explaining why? I mean I very much agree to the the thread you posted that explains why irate skip metrics and the graph will be "incorrect" (quoting directly: |
This is a healthy discussion, and I believe it may be an indicator that this isn't appropriate as a hard-and-fast rule. I'll also confess that while I have a decent understanding of the difference between I would defer a bit to @tomwilkie here, as this rule was his suggestion. I am inclined to either forego creating this rule, or clearly understand and document the intent behind it so that users can make an informed decision about whether they exclude it or not. |
Yeah I think in hindsight best not to mandate the use of irate; still worth having a rule that checks counters (ie anything ending in _total) is rate'd/irate'd/increased etc, no? |
That sounds useful for sure! I can't think of any use-case why you would not do that on a counter... |
Always use irate instead of rate.
The text was updated successfully, but these errors were encountered: