Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report extra metadata #115

Open
mariomac opened this issue May 17, 2023 · 1 comment
Open

Report extra metadata #115

mariomac opened this issue May 17, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@mariomac
Copy link
Contributor

From other services in the App O11y plugin, I see that they report many resource attributes that we don't, and they could be useful e.g. to differentiate between instances:

  • host.name
  • os.description
  • os.type
  • process.command_args
  • process.executable.name
  • process.executable.path
  • process.owner
  • process.pid
  • process.runtime.description (e.g. go version go1.19.2 linux/amd64)
  • process.runtime.name
  • service.instance.id
  • service.namespace
  • telemetry.sdk.language
  • telemetry.sdk.name
  • telemetry.sdk.version

If we detect that the process runs in a container:

  • container.id

If we detect that the process runs in K8s:

  • k8s.node.name
  • k8s.pod.name
  • k8s.namespace.name

For Kubernetes, the easiest way would be to just allow setting these values via env vars, then use the valueFrom clause in the deployment descriptors.

@mariomac mariomac added the enhancement New feature or request label May 17, 2023
@mariomac mariomac self-assigned this Jun 26, 2023
@mariomac
Copy link
Contributor Author

mariomac commented Jul 6, 2023

Maybe we should wait until most resource conventions move from Experimental to something more stable: https://opentelemetry.io/docs/specs/otel/resource/semantic_conventions/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant