Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support executables with both Gin and net/http #83

Closed
mariomac opened this issue Apr 26, 2023 · 1 comment
Closed

Support executables with both Gin and net/http #83

mariomac opened this issue Apr 26, 2023 · 1 comment

Comments

@mariomac
Copy link
Contributor

The way the instrumenter currently works, it searches either for net/http.HandlerFunc.ServeHTTP or github.com/gin-gonic/gin.(*Engine).ServeHTTP, and then adds an instrumentation point to the latest found function, but not to both.

This could lead to not being able to instrument customers that are progresssively migrating away from Gin to another framework.

@mariomac
Copy link
Contributor Author

Closing as it is not true. Current integration tests executable has both gin, gorilla and net/http

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant