Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prometheus scrape endpoint #110

Merged
merged 6 commits into from
May 11, 2023
Merged

Prometheus scrape endpoint #110

merged 6 commits into from
May 11, 2023

Conversation

mariomac
Copy link
Contributor

@mariomac mariomac commented May 11, 2023

It also fixes the OTEL metrics units from milliseconds to seconds, to be consistent with the latest OpenTelemetry specification.

Most of the PR files are just vendored dependencies

@mariomac mariomac requested a review from grcevski as a code owner May 11, 2023 12:48
@codecov-commenter
Copy link

codecov-commenter commented May 11, 2023

Codecov Report

Merging #110 (23631c3) into main (94bcce3) will decrease coverage by 30.60%.
The diff coverage is 19.33%.

@@             Coverage Diff             @@
##             main     #110       +/-   ##
===========================================
- Coverage   75.38%   44.78%   -30.60%     
===========================================
  Files          21       22        +1     
  Lines        1503     1601       +98     
===========================================
- Hits         1133      717      -416     
- Misses        276      833      +557     
+ Partials       94       51       -43     
Flag Coverage Δ
integration-test ?
unittests 44.78% <19.33%> (-3.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/ebpf/tracer.go 0.00% <0.00%> (-63.22%) ⬇️
pkg/pipe/config.go 53.33% <ø> (ø)
pkg/export/prom/prom.go 1.40% <1.40%> (ø)
pkg/export/otel/traces.go 78.85% <57.14%> (-0.88%) ⬇️
pkg/export/otel/metrics.go 70.88% <100.00%> (-8.45%) ⬇️
pkg/pipe/global/context.go 100.00% <100.00%> (ø)
pkg/pipe/instrumenter.go 82.14% <100.00%> (-8.49%) ⬇️
pkg/transform/spanner.go 80.95% <100.00%> (-2.39%) ⬇️

... and 12 files with indirect coverage changes

Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Amazing work!

@mariomac mariomac merged commit 6250511 into grafana:main May 11, 2023
3 checks passed
@mariomac mariomac deleted the prometheus branch May 11, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants