More linter fixes and configurable logging #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariomac
reviewed
Mar 7, 2023
pkg/goexec/instructions.go
Outdated
| @@ -57,7 +57,7 @@ func instrumentationPoints(elfF *elf.File, funcName string) (FuncOffsets, error) | |||
| if sec == nil { | |||
| return FuncOffsets{}, fmt.Errorf(".gosymtab section not found in target binary, make sure this is a Go application") | |||
| } | |||
| symTabRaw, err := sec.Data() | |||
| symTabRaw, _ := sec.Data() | |||
There was a problem hiding this comment.
Oops! I forgot to handle the error. Instead of ignoring it, we should handle it:
if err != nil {
return FuncOffsets{}, fmt.Errorf("getting memory section data: %w", err)
}
mariomac
requested changes
Mar 7, 2023
|
Done :) |
mariomac
approved these changes
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added few things to be able to run the first benchmark on pingserver:
pkgafter fixing all of the issues the new linter version found.otelhttpandpingserverbuildgoal be the default for the Makefile. I hope you don't mind, I guess I'm used to make doing all the work and I kept forgetting to runbuild. It used to pick upprereqsas the first goal by default. So right now, justmakedoes the full build.Here's an example of how I run the
otelhttptracer without printing and WARN log level: