DWARF info becoming optional #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #31.
The current behavior is: first, look for the debug information. If not found (or failed), then use the prefetched offsets.
For most cases, using directly the prefetched offsets would just work, but I think an scenario where checking first the debug info would avoid errors: someone updates the instrumented executable with a newer version of Go or a library, but keeps the instrumenter in and old version that do not include the updated offsets.
The code from the Go symbols table inspections is mostly imported from https://github.com/open-telemetry/opentelemetry-go-instrumentation