Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow LogLevel to affect ebpf c code #40

Merged
merged 2 commits into from
Mar 30, 2023

Conversation

grcevski
Copy link
Contributor

At the moment we have few bpf messages that are printed through bpf_printk. With this PR we allow the user space code to rewrite the constant to change the default log level the eBPF C code starts with. The same LogLevel configuration variable is used to affect both logging levels equally.

I've moved the debug messages that go into /sys/kernel/debug/tracing/trace_pipe to be debug only, while the rest are set as warn, which is the default logging level for eBPF.

Closes #39

@grcevski grcevski requested a review from mariomac March 29, 2023 20:11
@CLAassistant
Copy link

CLAassistant commented Mar 29, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@mariomac mariomac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@grcevski grcevski merged commit 81d7cf7 into grafana:main Mar 30, 2023
@grcevski grcevski deleted the ebpf_debug_level branch March 30, 2023 13:25
@grcevski
Copy link
Contributor Author

Thanks Mario!

@grcevski grcevski self-assigned this Mar 30, 2023
@grcevski grcevski added the enhancement New feature or request label Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for configuring of the logging level in the ebpf C code
3 participants