-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Probe goroutine create and exit for request time #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #49 +/- ##
==========================================
+ Coverage 51.13% 51.23% +0.10%
==========================================
Files 14 14
Lines 927 968 +41
==========================================
+ Hits 474 496 +22
- Misses 418 435 +17
- Partials 35 37 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
1 task
mariomac
approved these changes
Apr 13, 2023
Thanks Mario! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR we add two new uprobes, one at runtime.newproc1 and another at runtime.goexit1. When we capture the time at runtime.newproc1, we can tell the total request time, not just the service time.
I added nested spans in the traces to capture this information. When testing with our 10,000 QPS load driver, I was able to see pathological cases where the request time was dominated by the time the request waits in queue.
This PR is based on #46. It needs to be merged first.