Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track HTTP request content length #50

Merged
merged 5 commits into from
Apr 14, 2023
Merged

Conversation

grcevski
Copy link
Contributor

@grcevski grcevski commented Apr 12, 2023

With this PR we add support for tracking the content-length on HTTP requests. For GRPC since it's streaming by default it's not easy to find this information without recomputing values.

The PR was based on #49, so we need to merge that first.

  • Add tests for correctly tracking the request size

@grcevski grcevski added the enhancement New feature or request label Apr 12, 2023
@grcevski grcevski requested a review from mariomac April 13, 2023 17:39
@grcevski grcevski mentioned this pull request Apr 13, 2023
@grcevski grcevski merged commit 8fb1a05 into grafana:main Apr 14, 2023
2 checks passed
@grcevski grcevski deleted the track_sizes branch April 14, 2023 14:42
@grcevski
Copy link
Contributor Author

Thanks Mario!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants