Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow selecting executable by used ports #53

Merged
merged 1 commit into from
Apr 13, 2023
Merged

Conversation

mariomac
Copy link
Contributor

@mariomac mariomac commented Apr 13, 2023

Fixes issue #42

@mariomac mariomac requested a review from grcevski April 13, 2023 10:08
@codecov-commenter
Copy link

Codecov Report

Merging #53 (c4f28a6) into main (bc2f549) will decrease coverage by 1.45%.
The diff coverage is 19.73%.

@@            Coverage Diff             @@
##             main      #53      +/-   ##
==========================================
- Coverage   51.24%   49.79%   -1.45%     
==========================================
  Files          14       14              
  Lines         927      970      +43     
==========================================
+ Hits          475      483       +8     
- Misses        415      447      +32     
- Partials       37       40       +3     
Flag Coverage Δ
unittests 49.79% <19.73%> (-1.45%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/ebpf/nethttp/nethttp.go 0.00% <ø> (ø)
pkg/goexec/offsets.go 0.00% <0.00%> (ø)
pkg/goexec/file.go 36.95% <5.66%> (-7.42%) ⬇️
pkg/pipe/instrumenter.go 78.84% <57.14%> (-3.77%) ⬇️
pkg/goexec/structmembers.go 68.18% <66.66%> (+1.20%) ⬆️
pkg/pipe/config.go 53.33% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Really cool!

@mariomac mariomac merged commit 8ebee7e into grafana:main Apr 13, 2023
2 checks passed
@mariomac mariomac deleted the openport branch April 13, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants