Documentation skeleton #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #62 +/- ##
=======================================
Coverage 48.77% 48.77%
=======================================
Files 15 15
Lines 1060 1060
=======================================
Hits 517 517
Misses 501 501
Partials 42 42
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
grcevski
approved these changes
Apr 18, 2023
| * Using ringbuffer instead of perf_buffer | ||
| * despite the name, ringbuffer is faster | ||
| * We return status code | ||
| * We provide goroutine wait time (since the connection is accepted until the request is processed) for more accurate | ||
| metrics on overload scenarios. |
There was a problem hiding this comment.
Should we mention we also capture request sizes for HTTP?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates README and provides some placeholders to start writing the documentation and tutorials.