Match on process suffix instead of contains #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #73 +/- ##
=======================================
Coverage 46.82% 46.82%
=======================================
Files 15 15
Lines 1119 1119
=======================================
Hits 524 524
Misses 548 548
Partials 47 47
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mariomac
reviewed
Apr 20, 2023
pkg/goexec/file.go
Outdated
| @@ -51,7 +51,7 @@ func ProcessNamed(pathContains string) ProcessFinder { | |||
| continue | |||
| } | |||
|
|
|||
| if strings.Contains(exePath, pathContains) { | |||
| if strings.HasSuffix(exePath, pathContains) { | |||
There was a problem hiding this comment.
NitPick: maybe renaming pathContains by pathSuffix?
mariomac
approved these changes
Apr 20, 2023
Thanks Mario! I'll take a look at that grpc flakiness. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the name matcher for the instrumented process to look for the suffix in the full path, instead of matching a partial path. This should avoid false positives on matching the name of a process accidentally, e.g:
We shouldn't match
/serverin here/home/user/.vscode/extensions/rust-lang.rust-analyzer-0.3.1472-linux-x64/server/rust-analyzer, but we should match it here./server