Quickstart Tutorial + Fix endpoint handling #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariomac
added
bug
grcevski
approved these changes
Apr 20, 2023
| export GRAFANA_REGION="prod-eu-west-0" | ||
|
|
||
| export OTEL_EXPORTER_OTLP_ENDPOINT="https://otlp-gateway-${GRAFANA_REGION}.grafana.net/otlp" | ||
| export OTEL_EXPORTER_OTLP_PROTOCOL="http/protobuf" |
There was a problem hiding this comment.
Do we need to add explicit support for protobuf for the protocol to work, or it's somehow handled automatically? I thought we might need to use the oltptracegrpc?
There was a problem hiding this comment.
Ahh good question, let me double-check and remove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a quickstart tutorial.
During the development of the tutorial, I realized that we were incorrectly handling the
OTEL_EXPORTER_OTLP_ENDPOINTvariable, mostly due to a wrong interpretation of the library documentation from my side.The
OTEL_EXPORTER_OTLP_ENDPOINTmust be a complete URL including the schema and any optional path, and we were just treating it as a host:port.This required to change some tests, and might break some scripts we already have for local testing.