Add support for keepalive request time #82
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a client is using keepalive for a request connection, the Go http server code will keep the goroutine live since the connection doesn't drop. This slightly defeats our request time vs. service time tracking, because there might be delay on processing the request after new data arrives on the old connection.
To mitigate this, we add a probe on
startBackroundRead
which is the code that will process the incoming data. This function is called very soon after the connection sees new data, so we'll be able to capture the full request time again, even in keepalive mode.