Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: HTTP client request tracking #85

Closed
wants to merge 4 commits into from

Conversation

grcevski
Copy link
Contributor

This PR introduces nested span tracking, although it's not perfect as it doesn't deal with async HTTP client requests. Essentially we instrument the HTTP client and make client spans, but we also track the parent server request scope.

I still need to do a lot of test writing and validation.

@grcevski grcevski added the enhancement New feature or request label Apr 26, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #85 (039a424) into main (2ceff1a) will decrease coverage by 0.42%.
The diff coverage is 54.63%.

@@            Coverage Diff             @@
##             main      #85      +/-   ##
==========================================
- Coverage   46.58%   46.17%   -0.42%     
==========================================
  Files          15       15              
  Lines        1172     1241      +69     
==========================================
+ Hits          546      573      +27     
- Misses        577      615      +38     
- Partials       49       53       +4     
Flag Coverage Δ
unittests 46.17% <54.63%> (-0.42%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/ebpf/nethttp/bpf_debug_bpfel_x86.go 0.00% <0.00%> (ø)
pkg/ebpf/nethttp/nethttp.go 0.00% <0.00%> (ø)
pkg/pipe/config.go 48.48% <ø> (ø)
pkg/transform/spanner.go 81.48% <50.00%> (-0.80%) ⬇️
pkg/export/otel/traces.go 63.29% <56.96%> (-10.19%) ⬇️
pkg/pipe/instrumenter.go 81.35% <100.00%> (+1.35%) ⬆️

@grcevski
Copy link
Contributor Author

Code structure changed quite a bit. I'm going to close this PR and start from scratch.

@grcevski grcevski closed this Apr 27, 2023
@grcevski grcevski deleted the http_client branch April 27, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants