Increase testing coverage (and some related refactors) #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariomac
commented
May 2, 2023
| // TODO: add shutdown hook for graceful stop | ||
| bp.Run(context.TODO()) | ||
|
|
||
| // Adding shutdown hook for graceful stop |
There was a problem hiding this comment.
@grcevski this will conflict with your ongoing work, but I had to do it here because the runtime coverage generator requires a graceful stop
There was a problem hiding this comment.
Oh that's fine, not a problem. I'll merge.
mariomac
changed the title
grcevski
approved these changes
May 2, 2023
| // TODO: add shutdown hook for graceful stop | ||
| bp.Run(context.TODO()) | ||
|
|
||
| // Adding shutdown hook for graceful stop |
There was a problem hiding this comment.
Oh that's fine, not a problem. I'll merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raised coverage from <40% to 73,8%
New unit tests were created, but the improvement has been achieved also by generating and uploading coverage data from integration tests.
In linting, cyclomatic complexity limit has been decreased to 10, and few refactors were done to let linting pass in some complex functions.