Skip to content
This repository has been archived by the owner on Jul 19, 2023. It is now read-only.

Diff memory profiles #124

Merged
merged 16 commits into from Aug 4, 2022
Merged

Diff memory profiles #124

merged 16 commits into from Aug 4, 2022

Conversation

cyriltovena
Copy link
Collaborator

No description provided.

@simonswine simonswine mentioned this pull request Jul 29, 2022
@cyriltovena
Copy link
Collaborator Author

This will move forward #118

@cyriltovena cyriltovena changed the title Diff alloc type of profiles Diff memory profiles Jul 29, 2022
@cyriltovena cyriltovena added the kind/enhancement New feature or request label Jul 29, 2022
@cyriltovena cyriltovena marked this pull request as ready for review July 29, 2022 14:35
@cyriltovena
Copy link
Collaborator Author

I think this is good to go unless we want to include the cleanup of highest samples now.

@cyriltovena
Copy link
Collaborator Author

The effect of diffing

image

Faster queries and less space on disk

Copy link
Collaborator

@simonswine simonswine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a massive improvement. LGTM!

pkg/firedb/metrics.go Outdated Show resolved Hide resolved
pkg/firedb/delta.go Outdated Show resolved Hide resolved
pkg/firedb/delta_test.go Show resolved Hide resolved
@cyriltovena cyriltovena merged commit ef4ee26 into main Aug 4, 2022
@cyriltovena cyriltovena deleted the diff-memory branch August 4, 2022 14:47
simonswine pushed a commit to simonswine/pyroscope that referenced this pull request Jun 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants