This repository has been archived by the owner on Jul 19, 2023. It is now read-only.
Implements a basic SelectSeries API for querying metrics on profiles #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyriltovena
commented
Aug 25, 2022
| response.Error = err | ||
| return response | ||
| } | ||
| // todo remove me and add the series to the frame. |
There was a problem hiding this comment.
@aocenas will take over from here.
cyriltovena
commented
Aug 25, 2022
| } | ||
|
|
||
| // Equal compares two protobuf messages ignoring extra generated proto fields. | ||
| func EqualProto(t *testing.T, expected, actual interface{}) { |
There was a problem hiding this comment.
When comparing proto I suggest everyone to use that one, the output is way more useful and it automatically ignore proto fields.
Closed
simonswine
approved these changes
Aug 30, 2022
| Profiles: tt.in, | ||
| }), nil) | ||
| return q, nil | ||
| }, log.NewLogfmtLogger(os.Stdout)) |
There was a problem hiding this comment.
Not too sure if this was an oversight or not, feel free to ignore:
Suggested change
| }, log.NewLogfmtLogger(os.Stdout)) | |
| }, log.NewLogfmtLogger(os.Stderr)) |
There was a problem hiding this comment.
on my env it doesn't really matter.
simonswine
pushed a commit
to simonswine/pyroscope
that referenced
this pull request
Jun 30, 2023
Implements a basic SelectSeries API for querying metrics on profiles
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.