Skip to content
This repository has been archived by the owner on Nov 19, 2020. It is now read-only.

data(.Frame) and protobuf types #8

Closed
kylebrandt opened this issue Sep 6, 2019 · 1 comment
Closed

data(.Frame) and protobuf types #8

kylebrandt opened this issue Sep 6, 2019 · 1 comment

Comments

@kylebrandt
Copy link
Contributor

kylebrandt commented Sep 6, 2019

When working with protobuf types get generated from the protobuf generated files. However, we will want the data package to provide types that are easy to work with for developing plugins (and for GEL operations.)

@marefr and I talked about this briefly, we are not sure what the best way to do the code here is. We could maybe have Go type for a Frame and assert the protobuf type is of type Frame. Or maybe there are better ways to do this. Not sure at the moment.

We will also want the Frame type to serialize in a defined consistent way over json for the frontend to consume.

Relates to:

@kylebrandt
Copy link
Contributor Author

We Believe:

  • There is a package for the protobuf types
  • And a Go package that wraps those, so developers are not interacting with the Go Types

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
GEL TODOs
  
Done
Development

No branches or pull requests

2 participants