Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select form component does not show entire list in some scenarios #153

Closed
mary-sitzenstatter opened this issue Dec 3, 2021 · 2 comments
Closed
Labels
type/bug Unexpected behavior or a feature is broken

Comments

@mary-sitzenstatter
Copy link

When screen size is short, the select form component list appears above the field. In these scenarios, the list is cut off and the user cannot see all list options. Observe below:

Short screen
This is where we see the issue
image

Longer screen
This is where the list is rendered correctly
image

@mary-sitzenstatter mary-sitzenstatter self-assigned this Dec 3, 2021
@ashharrison90 ashharrison90 transferred this issue from grafana/grafana Dec 6, 2021
@ashharrison90
Copy link

believe all we need to do is set menuShouldPortal on the Select here: https://github.com/grafana/github-datasource/blob/main/src/components/FieldSelect.tsx#L26

this will become the default behaviour in Grafana 9

@ashharrison90 ashharrison90 added the type/bug Unexpected behavior or a feature is broken label Dec 6, 2021
@cletter7
Copy link
Contributor

I've checked and it's fixed now. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Unexpected behavior or a feature is broken
Projects
None yet
Development

No branches or pull requests

3 participants