Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support caching for async queries #14

Closed
kevinwcyu opened this issue Mar 28, 2023 · 2 comments
Closed

Support caching for async queries #14

kevinwcyu opened this issue Mar 28, 2023 · 2 comments
Assignees

Comments

@kevinwcyu
Copy link
Collaborator

See the issue description for cloudwatch for some background info. That issue affects redshift and athena when going through the async query flow. This is because we bypass cache in DataSourceWithAsyncBackend when performing an async query.

@kevinwcyu kevinwcyu added the bug Something isn't working label Mar 28, 2023
@iwysiu
Copy link
Contributor

iwysiu commented Jun 26, 2023

It's currently not being cached because when we implemented the async queries, we didn't want to cache when we sent a response for a still running query to the frontend. (In async queries the frontend polls periodically until it gets a done response) If we cached a still running response, then the query would never finish. It depends on how the code is laid out, but the solution would probably be to only cache "done" responses with actual data.

@iwysiu iwysiu self-assigned this Jun 26, 2023
@iwysiu iwysiu changed the title cachedQueries field in usage insights is not getting updated Support caching for async queries Jul 21, 2023
@iwysiu
Copy link
Contributor

iwysiu commented Jul 21, 2023

Done in grafana/grafana-aws-sdk#85 , grafana/grafana#71682 , and #17

@iwysiu iwysiu closed this as completed Jul 21, 2023
@iwysiu iwysiu added enhancement New feature or request datasource/redshift effort/large and removed bug Something isn't working labels Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

2 participants