Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undocumented/unintentional(?) Breaking change #123

Closed
sarahzinger opened this issue Jan 31, 2024 · 1 comment
Closed

Undocumented/unintentional(?) Breaking change #123

sarahzinger opened this issue Jan 31, 2024 · 1 comment

Comments

@sarahzinger
Copy link
Member

I was working with Athena and the grafana-aws-sdk locally and tried to upgrade and noticed that when I upgrade from 0.20 to 0.21 I get a lot of build errors, as the interfaces have changed for many methods now I think?

for example we went from
func (*awsds.AsyncAWSDatasource).NewDatasource(settings backend.DataSourceInstanceSettings)
to
func (*awsds.AsyncAWSDatasource).NewDatasource(ctx context.Context, settings backend.DataSourceInstanceSettings)

I think we are the only folks using this but we should respect semver if we can just in case. Not sure if its possible at this point to change the version? Or if there is a way to do this without breaking changes maybe we can fix that? If not maybe we should just make the next release a major change and note the error?

@sarahzinger
Copy link
Member Author

@iwysiu informs me that this is not actually a bug because grafana-aws-sdk is still in version 0.x.x which means that we're still in the pre-release stage and there's no such thing as a breaking change which makes sense, and tbh I agree this lib is not really in a place where we can't guarantee no breaking changes yet. So closing as not planned since there's no work here haha. Upgrading Athena now to handle the breaking changes.

@sarahzinger sarahzinger closed this as not planned Won't fix, can't repro, duplicate, stale Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

1 participant