Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move athena and redshift MakeDatasourceFactory into grafana-aws-sdk #131

Open
njvrzm opened this issue Feb 28, 2024 · 1 comment
Open

Move athena and redshift MakeDatasourceFactory into grafana-aws-sdk #131

njvrzm opened this issue Feb 28, 2024 · 1 comment
Assignees
@njvrzm
Labels
grafana-aws-sdk type/bug

Comments

@njvrzm
Copy link
Contributor

njvrzm commented Feb 28, 2024

The athena and redshift plugins got the same fix (grafana/athena-datasource#314) for a shared credentials caching issue but this introduced some duplicated code and of course won't help any new datasources based on the sdk. The duplicated function should be refactored to work generically and moved into the sdk, then athena and redshift should be updated to use it.
@njvrzm njvrzm self-assigned this Mar 22, 2024
@njvrzm
Copy link
Contributor Author

njvrzm commented Jun 10, 2024

Moving this back to the back burner in favor of mulitenancy work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@njvrzm njvrzm

Labels
grafana-aws-sdk type/bug
Projects
AWS Datasources
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
1 participant
@njvrzm