Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Space as Delimiter #193

Closed
mrbesen opened this issue Apr 28, 2022 · 3 comments
Closed

Space as Delimiter #193

mrbesen opened this issue Apr 28, 2022 · 3 comments
Labels
hacktoberfest type/feature-request Requested new feature or enhancement

Comments

@mrbesen
Copy link

mrbesen commented Apr 28, 2022

I have a unconventional csv file, that has space as delimiter. So i thought, i can just add that to the delimiter list and done.
But i guess there are many more weird csv files with very unconventional delimiters. So adding a "custom Delimiter" option would be great to define any delimiter a user could want. Sadly i am not familiar with reactjs at all.
I tried my best to implement it here:

https://github.com/mrbesen/grafana-csv-datasource

but it wont quite work as expected. (Hence no PR) Maybe someone more experienced might have a look at it?

I wanted to make the Input hide, when "Custom Delimiter" is not selected, but that is way out of my reach.

@zoltanbedi zoltanbedi changed the title Custom Delimiter Space as Delimiter Oct 9, 2023
@zoltanbedi zoltanbedi added type/feature-request Requested new feature or enhancement hacktoberfest labels Oct 9, 2023
@zoltanbedi
Copy link
Member

Adding a new option (Space) here https://github.com/grafana/grafana-csv-datasource/blob/main/src/components/FieldEditor.tsx#L25 would be good I think.

@mrbesen
Copy link
Author

mrbesen commented Nov 4, 2023

Yes, that would solve my problem, but maybe there is someone elese having some obscure delimiter that we cant even think of. So i would just allow for a custom string as delimiter.

@yesoreyeram
Copy link
Collaborator

Hiya. I would recommend using Infinity datasource plugin which supports custom delimiter and also now actively maintained by Grafana Labs.

Eventually in an effort to unify our JSON/CSV plugins, we are planning to deprecate this CSV plugin in favour of Infinity datasource plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest type/feature-request Requested new feature or enhancement
Projects
Status: Complete
Development

No branches or pull requests

3 participants