Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

height=-1 stop working #380

Closed
amnonh opened this issue Nov 2, 2022 · 3 comments
Closed

height=-1 stop working #380

amnonh opened this issue Nov 2, 2022 · 3 comments
Labels
help wanted Extra attention is needed needs more info

Comments

@amnonh
Copy link

amnonh commented Nov 2, 2022

What happened:
Using the latest version 3.6.1 setting the image height=-1 no longer works and the image height is set to 1200.

What you expected to happen:
A fullpage renderer
How to reproduce it (as minimally and precisely as possible):
use any grafana dashboard that is more than 1200 height and render it
Anything else we need to know?:
I am using repeated panels if it makes a difference.

Environment:

  • Grafana Image Renderer version:3.6.1
  • Grafana version: 9.2.3
  • Installed plugin or remote renderer service: docker container
  • OS Grafana Image Renderer is installed on: docker container
  • User OS & Browser: docker container
  • Others:
@joanlopez joanlopez added help wanted Extra attention is needed needs more info labels Nov 23, 2022
@joanlopez
Copy link
Collaborator

Hi @spinillos,

Does it sound familiar to you? Maybe something we could have broken in one of the latest changes?
Otherwise, we'll need to investigate from zero and it will take longer (cc/ @amnonh).

Thanks!

@spinillos
Copy link
Member

I understand that the issue is here. This code was added to make full page screenshots and its setting the height as a proportion of the width.

heigth=-1 previously was setting the height from the default config here and here.

Maybe set height=0 does the trick.

@Clarity-89
Copy link
Contributor

Closing the issue for now, feel free to reopen if the issue persists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed needs more info
Projects
None yet
Development

No branches or pull requests

4 participants