Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renderer intermittent crash #381

Closed
Bujupah opened this issue Nov 3, 2022 · 2 comments
Closed

Renderer intermittent crash #381

Bujupah opened this issue Nov 3, 2022 · 2 comments

Comments

@Bujupah
Copy link
Contributor

Bujupah commented Nov 3, 2022 •
edited

What happened:
Renderer crash

How to reproduce it (as minimally and precisely as possible):
This is intermittently happening when datasource queries or any dashboard request fails to load in the chromium instance...

Need to know
After debugging the code, I found out that browser request error can be null and this will cause req.failure().errorText to fail and crash since it is somehow null pointer exception...

Environment:

  • Grafana Image Renderer version: v3.6.1
  • Grafana version: v9.0.2
  • Installed plugin or remote renderer service: remote
  • OS Grafana Image Renderer is installed on: Docker(alpine)/Linux/Windows
  • User OS & Browser: Chrome
@Bujupah
Copy link
Contributor Author

Bujupah commented Nov 3, 2022

Raised a PR to fix and avoid this behavior #379

@Bujupah Bujupah mentioned this issue Feb 27, 2023
Merged
@Bujupah
Copy link
Contributor Author

Bujupah commented Feb 27, 2023

Issue is fixed in #403

@Bujupah Bujupah closed this as completed Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Bujupah