Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to edit maxResults sent to the lambdas #86

Open
msshui-amzn opened this issue Aug 4, 2022 · 2 comments
Open

Allow users to edit maxResults sent to the lambdas #86

msshui-amzn opened this issue Aug 4, 2022 · 2 comments

Comments

@msshui-amzn
Copy link
Contributor

It seems users want the ability to increase the maxResults we use (100 by default) as the pagination latency is frustatingly slow.
This is for calling the 'Get Property Value by x' or 'Get Alarms' APIs.

This I believe would be a good addition to make but we should enforce 100 as the minimum. At least until we find a good use case to decrease it.

User complaint:
"In the event sent to the connector lambda there is a maxResults parameter. I assume this is the number of results the lambda should return for a single call, and if the total number of results from the query is larger it should paginate using nextToken. Can this value be configured by the user? 100 seems a really low value and I observe that the pagination latency is killing the dashboard performances. Moreover, for widgets such as Gauges, the Gauges change value for each page, which is really annoying."

@msshui-amzn
Copy link
Contributor Author

There is a backlog item created for supporting interpolation within sitewise 1p.
Currently what customer can do is to implement interpolation in their lambda connector. And Linear interpolation is supported.
SIM https://sim.amazon.com/issues/IOTROCI-5402
API doc https://docs.aws.amazon.com/iot-twinmaker/latest/apireference/API_GetPropertyValueHistory.html#tm-GetPropertyValueHistory-request-interpolation https://docs.aws.amazon.com/iot-twinmaker/latest/guide/data-connector-interfaces.html#DataReaderByEntity-connector

@msshui-amzn
Copy link
Contributor Author

The idea is instead of modifying the maxResults, we are smarter with interpolation to reduce the amount of data points that needs returning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

3 participants