Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please remove the time type length checking in detectFieldType #82

Closed
jiulian opened this issue Mar 19, 2021 · 1 comment
Closed

Please remove the time type length checking in detectFieldType #82

jiulian opened this issue Mar 19, 2021 · 1 comment
Labels
type/feature-request Requested new feature or enhancement

Comments

@jiulian
Copy link

jiulian commented Mar 19, 2021

https://github.com/marcusolsson/grafana-json-datasource/blob/4352df6d0a48dcbf14597d575a7cbc9f79a2a590/src/datasource.ts#L202-L209

This checking will cause the value to wrongly display to time value, it is quite annoying.
For example 2257757352, we want to display this length of the value in our project, but it displayed '2041-07-18 18:49:12'.

@marcusolsson
Copy link
Contributor

Now that we have support for setting the type explicitly, I think it's reasonable to not automatically detect Unix epochs. In the meantime, you should be able to fix this by setting the type as Number.

@marcusolsson marcusolsson added the type/feature-request Requested new feature or enhancement label Mar 21, 2021
@marcusolsson marcusolsson added this to To do in Grafana Plugins via automation Mar 21, 2021
@marcusolsson marcusolsson moved this from Backlog to In progress in Grafana Plugins Apr 7, 2021
Grafana Plugins automation moved this from In progress to Done Apr 11, 2021
@marcusolsson marcusolsson removed this from Done in Grafana Plugins Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature-request Requested new feature or enhancement
Projects
None yet
Development

No branches or pull requests

2 participants