Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow reading config from file #3

Closed
mrueg opened this issue May 3, 2019 · 3 comments · Fixed by #35
Closed

Allow reading config from file #3

mrueg opened this issue May 3, 2019 · 3 comments · Fixed by #35
Assignees
@briangann
Labels
enhancement New feature or request
Projects
grafana-kiosk

Comments

@mrueg
Copy link

mrueg commented May 3, 2019

With passwords as parameters, credentials might get exposed accidentally through procfs (e.g. via top).
@briangann briangann added the enhancement New feature or request label May 15, 2019
@briangann
Copy link
Collaborator

great idea, will add that ability!

@briangann briangann self-assigned this May 15, 2019
@briangann briangann added this to To do in grafana-kiosk May 15, 2019
@briangann
Copy link
Collaborator

I'll be working on this enhancement over the weekend

@briangann briangann moved this from To do to In progress in grafana-kiosk Dec 20, 2019
@briangann
Copy link
Collaborator

that was a very long weekend! A PR is in the works now though!

@briangann briangann mentioned this issue May 16, 2020
Merged
6 tasks
grafana-kiosk automation moved this from In progress to Done May 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@briangann briangann

Labels
enhancement New feature or request
Projects
grafana-kiosk
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update to go 1.14 and modules to prevent crash in v7 grafana/grafana-kiosk
2 participants
@mrueg @briangann