Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto playlist navigation not working in armv7 and amd64 #32

Closed
akararsse opened this issue Apr 16, 2020 · 7 comments
Closed

auto playlist navigation not working in armv7 and amd64 #32

akararsse opened this issue Apr 16, 2020 · 7 comments
Labels
bug Something isn't working

Comments

@akararsse
Copy link

I have tried release 1.0.1 and used the armv7 and amd64 binary packages in a Tinker board running in Tinker OS (debian) and Linux Mint respectively. The following Behaviour were observed:

  • Both the armv7 and amd64 binary files fills the fields in the login page of the grafana instance i am connecting to, thus auto login is working.
  • But after logging in it should redirect to the playlist, but instead it stays in the grafana main page . I have to manually click on the start playlist after navigating to the playlist page to start it.
    Here is the command that i am running and the outputs:
$ ./grafana-kiosk.linux.armv7 --URL https://insight.desec.io/grafana/playlists/play/1 --login-method local --username $uname --password $password --playlist
2020/04/16 11:15:18 playlist
2020/04/16 11:15:18 DISPLAY not set, autosetting to :0.0
2020/04/16 11:15:18 DISPLAY= :0.0
2020/04/16 11:15:18 XAUTHORITY not set, autosetting
2020/04/16 11:15:18 XAUTHORITY= /home/linaro/.Xauthority
2020/04/16 11:15:18 Launching local login kiosk
2020/04/16 11:15:20 KioskMode: Fullscreen
2020/04/16 11:15:20 Navigating to  https://insight.desec.io/grafana/playlists/play/1?inactive=1&kiosk=1&autofitpanels
@akararsse akararsse changed the title auto playlist navigation not working in armv7 auto playlist navigation not working in armv7 and amd64 Apr 16, 2020
@AlexHeylin
Copy link
Contributor

I'm new to this code, but from what I can make out - one the login is completed this code just lets Chrome get on with it - starting the playlist after login is down to Grafana telling Chrome what to do. Have you confirmed that Chrome running on those same machines goes from the URL above to the playlist?
What version of Grafana? If not latest, please reproduce with latest stable.

@peterthomassen
Copy link

Thanks for getting back, @AlexHeylin. Yes, the link works and does start the playlist if I manually login beforehand. The Grafana version we run is the current version from the official Docker image.

@AlexHeylin
Copy link
Contributor

@peterthomassen it might be the way you worded that or it might be what you're actually doing - so sorry to recheck this but it sounds like you're logging in and THEN calling the playlist url?

What happens if you log out of Grafana, close all browser windows, and then in a fresh Chrome window call the playlist url and login - does the playlist start?

I ask, because that's exactly what the code does (as far as I can tell).

@peterthomassen
Copy link

Ah, you are right: If I use the link https://insight.desec.io/grafana/playlists/play/1?inactive=1&kiosk=1&autofitpanels without logging in first, I get direct to the log in page, and after log in, there's just the Grafana main page. The playlist does not start.

When opening the link while logged in, the playlist does start.

So it seems like the URL is correct, but the post-login redirect is not working properly. That's a Grafana bug, I suppose?

@peterthomassen
Copy link

Actually, I double-checked versions, and apparently a new Grafana version has appeared since opening the bug. After the upgrade, the URL leads to the login form, and after login correctly redirects to the dashboard. So, I guess this has been fixed!

@AlexHeylin
Copy link
Contributor

Great news! Are you able to close this issue? If not, perhaps add "Resolved:" to the front of the title. As I'm not on the project team, I can't close it. Thanks

@briangann
Copy link
Collaborator

there was a redirect bug in Grafana core causing this, took a while but the PR to fix it was merged in :)

@briangann briangann added the bug Something isn't working label May 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants